Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Load settings when extension has been enabled #758

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jul 15, 2024

Description

When in a regular profile where the extension is already installed, in this profile if the user disables and then enables the extension, the settings stored by service worker are destroyed. This PR aims to restore the extension settings once the extension is enabled.

Relevant Technical Choices

Testing Instructions

  • Clone this branch, in the terminal run npm run build:all.
  • Load the extension in a new browser instance.
  • Go to example.com then enable multi tab debugging and analyse 2 different tabs together.
  • Now to go chrome://extensions page disable the extension and then enable it.
  • Now you should still be able to see that multi tab debugging is still on.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Jul 15, 2024
@amovar18 amovar18 marked this pull request as ready for review July 15, 2024 08:29
@amovar18 amovar18 requested a review from mohdsayed July 16, 2024 12:11
@amovar18 amovar18 added this to the v1.0.0 milestone Jul 16, 2024
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I pushed some refactoring changes.

@mohdsayed mohdsayed merged commit cc8007b into develop Jul 18, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/rectify-options-on-enable branch July 18, 2024 06:25
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants